Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ibc basic docs #3766

Merged
merged 1 commit into from
Nov 22, 2023
Merged

fix: ibc basic docs #3766

merged 1 commit into from
Nov 22, 2023

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented Nov 22, 2023

No description provided.

@Pantani Pantani self-assigned this Nov 22, 2023
@github-actions GitHub Actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit 6a490c9):

https://igntservices-docs--pr3766-fix-ibc-basic-docs-7hnctpgt.web.app

(expires Wed, 29 Nov 2023 01:38:45 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 95379efd94dd497aaa37c2d0354e6e2cafca5ec5

@Pantani Pantani added the skip-changelog Don't check changelog for new entries label Nov 22, 2023
julienrbrt
julienrbrt approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference:

cli/ignite/templates/ibc/files/packet/messages/x/{{moduleName}}/keeper/msg_server_{{packetName}}.go.plush

Line 23 in 4048162

_, err := k.Transmit<%= packetName.UpperCamel %>Packet(

@julienrbrt julienrbrt merged commit 9fe1f4c into main Nov 22, 2023
27 of 28 checks passed
@julienrbrt julienrbrt deleted the fix/ibc-basic-docs branch November 22, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@salmad3 salmad3 salmad3 approved these changes

@toschdev toschdev Awaiting requested review from toschdev toschdev is a code owner

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

Assignees

@Pantani Pantani

Labels
skip-changelog Don't check changelog for new entries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pantani @salmad3 @julienrbrt